[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1682265 - /subversion/trunk/subversion/libsvn_fs_fs/util.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Fri, 29 May 2015 16:15:41 +0300

On 28 May 2015 at 23:55, Bert Huijben <bert_at_qqmail.nl> wrote:
> In this case the log message documented that it fixed ‘a problem on
> Windows’, which would suggest at least some Windows testing
> [[
> Correctly fsync() after renames in FSFS on Win32. We must flush the disk
> buffers after the rename, otherwise the metadata may not be persistent.
> Moreover, if the rename is degraded to a copy by Win32, we won't even have
> the complete file contents on disk without a buffer flush.
> ]]
>
> The original code worked just fine in 1.7 and 1.8 before this patch, so some
> explanation on what problem is fixed, how to reproduce the problem and how
> this impacts performance would be welcome.
>
+1.

[...]

>> >> Did
>> >> you able to reproduce data corruption on VM?
>> >
>> >
>> > No. But I did not even try.
>> >
>> I really hope that you have tested your patch on Windows before commit.
>
> I really hope you're joking. We've never required or expected testing on all
> platforms, from anyone.
>
Do you say that testing platform specific fix on the platform affected
is not good practice

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com
Received on 2015-05-29 15:17:02 CEST

This is an archived mail posted to the Subversion Dev mailing list.