[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sat, 23 May 2015 11:10:33 +0000

Evgeny Kotkov wrote on Thu, May 21, 2015 at 18:23:22 +0300:
> @@ -2464,24 +2452,26 @@ svn_repos_verify_fs3(svn_repos_t *repos,
> cancel_func, cancel_baton,
> iterpool);
>
> + if (err && err->apr_err == SVN_ERR_CANCELLED)
> + ...
> + else if (err && !keep_going)
> + ...
> + else if (err && keep_going)
> + ...
> + else if (!err && notify_func)

The "!err &&" part of last condition is tautologic. I'd remove it,
leaving the condition as just "[else] ifá(notify_func)".
Received on 2015-05-23 13:10:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.