Re: Segfault in Perl bindings when commit touches a large number of files

On Fri, May 22, 2015 at 6:07 PM, Philip Martin <philip_at_codematters.co.uk>
wrote:

> It would help if I built the correct tree. No, that is not enough, the
> regression tests fail.
>

No surprise here:
(1) Your patch simply means: ignore the result_digest, but also produce no
return value for it.
But users of the Perl wrapper still expect it to return 3 items:
the magical md5sum, the handler and the baton. Now the wrapper returns only
the latter two.
(2) So you should should at least return undef as the first item,e.g

%typemap(argout) unsigned char *result_digest {
   %append_output(&PL_sv_undef);
}

(3) This will make t/5delta.t fail, as it tests for the magical sum which
is gone now.

But I'm not entirely convinced that the bug is really in the construction
of the magical md5sum.
Maybe git-svn is to blame, perhaps a problem with the lifetime of the pools
it uses...

Cheers, Roderich
Received on 2015-05-22 18:26:01 CEST