[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

From: Branko Čibej <brane_at_wandisco.com>
Date: Fri, 22 May 2015 14:25:46 +0200

I mean we could leave the current 1.8.x backport proposal unchanged.
Alternatively, tweaking your patch to make the new API private for 1.8.x is
fine; probably even better as it's likely to make future backports easier.
On 22 May 2015 12:46 pm, "Philip Martin" <philip.martin_at_wandisco.com> wrote:

> Branko Čibej <brane_at_wandisco.com> writes:
>
> > On 22.05.2015 10:50, Philip Martin wrote:
> >>
> >> Another approach would be to have a function to enable flushing directly
> >> on the stream created by svn_stream_from_aprfile2() without creating a
> >> new stream. This is probably the smallest/simplest patch. After
> >> reverting r1680819:
> >
> > [...]
> >
> > Big +1! Let's do it this way. We can keep the 1.8.x backport unchanged,
> too.
>
> Not sure what you mean by 1.8.x being unchanged. My patch has a new
> public API and a 1.8.x backport would make it private, unless we make
> the new API private everywhere.
>
> --
> Philip Martin | Subversion Committer
> WANdisco // *Non-Stop Data*
>
Received on 2015-05-22 14:26:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.