[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Subversion configure script broken for serf if sysroot path contains "-D"

From: Branko ─îibej <brane_at_wandisco.com>
Date: Thu, 21 May 2015 17:32:56 +0200

On 21.05.2015 15:54, Bruce Bye wrote:
>
>> > But then, since what the code is actually trying to get is the
>> include path and not the full cflags, perhaps it could instead
>> request --variable=includedir from pkg-config, and not need to munge
>> the string at all.
>>
>> Do you mind trying that? I'm sure a patch that does away with the
>> regex filter entirely would be welcome.
>>
> The below patch works for me:
> diff --git a/build/ac-macros/serf.m4 b/build/ac-macros/serf.m4
> index ae11e75..6549147 100644
> --- a/build/ac-macros/serf.m4
> +++ b/build/ac-macros/serf.m4
> @@ -143,7 +143,7 @@ AC_DEFUN(SVN_SERF_PKG_CONFIG,
> if $PKG_CONFIG $serf_major
> --atleast-version=$serf_check_version; then
> AC_MSG_RESULT([yes])
> serf_found=yes
> - SVN_SERF_INCLUDES=[`$PKG_CONFIG $serf_major --cflags | $SED
> -e 's/-D[^ ]*//g'`]
> + SVN_SERF_INCLUDES="-I`$PKG_CONFIG $serf_major
> --variable=includedir`"
> SVN_SERF_LIBS=`$PKG_CONFIG $serf_major --libs`
> break
> else

Um. What happens if we need more than one include path for Serf?

-- Brane
Received on 2015-05-21 17:33:48 CEST

This is an archived mail posted to the Subversion Dev mailing list.