Re: [PATCH] fsfs7 index offset validation

On Mon, May 18, 2015 at 11:27 AM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:

> On 18 May 2015 at 02:16, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> > Stefan,
> >
> > How about the following patch to sanity check the rev file footer?
> >
> [...]
>
> >
> > The error looks like this:
> >
> > subversion/libsvn_fs_fs/rev_file.c:263,
> > subversion/libsvn_fs_fs/low_level.c:212:
> (apr_err=SVN_ERR_INCORRECT_PARAMS)
> > svn: E200004: Invalid L2P offset in revision footer
> > subversion/libsvn_subr/string.c:986:
> (apr_err=SVN_ERR_INCORRECT_PARAMS)
> > svn: E200004: Number '888' is out of range '[0, 546]'
> >
> It would be nice to have revision number or filename as a part of error
> message.
>

Done in r1680476.

-- Stefan^2.
Received on 2015-05-20 09:57:29 CEST