[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1679228 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Tue, 19 May 2015 20:01:22 +0300

On 18 May 2015 at 02:25, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> Ivan Zhakov wrote on Fri, May 15, 2015 at 14:31:13 +0300:
>> On 14 May 2015 at 17:20, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
>> > ivan_at_apache.org wrote on Wed, May 13, 2015 at 15:37:18 -0000:
>> >> * subversion/tests/libsvn_fs/fs-test.c
>> >> (freeze_and_commit): Use "/" instead of "" as PATH argument for
>> >> svn_fs_change_node_prop().
>> >
>> > What was the reason for the change? The FS API explicitly accepts both
>> > "" and "/" as valid spellings of the root directory. (See svn_fs.h:1438)
>> >
>> You're right, but I think using canonical FS path is better for
>> consistency: all other tests if this file uses canonical FS paths.
>
> Actually, some tests use "" and others use "/". I think that's exactly
> right: both syntaxes are valid inputs and both of them have test coverage.
Makes sense. Reverted my change in r1680346.

-- 
Ivan Zhakov
Received on 2015-05-19 19:01:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.