[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fs-test 44 XPASS

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 06 May 2015 10:07:58 +0100

Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com> writes:

> Here is what I believe causes the different behaviour between
> test runs. To support read function that may block, e.g. wait for
> network buffers to flush, writes have been made non-blocking
> if they don't update existing cache entries. If the write lock can
> not be acquired immediately in that case, the new item will simply
> not be added to the cache.
>
> This behaviour is optional and can be disabled via flag:
>
> [[[
> Index: subversion/libsvn_subr/cache_config.c
> ===================================================================
> --- subversion/libsvn_subr/cache_config.c (revision 1675401)
> +++ subversion/libsvn_subr/cache_config.c (working copy)
> @@ -126,7 +126,7 @@
> (apr_size_t)(cache_size / 5),
> 0,
> ! svn_cache_config_get()->single_threaded,
> - FALSE,
> + TRUE,
> pool);
>
> /* Some error occurred. Most likely it's an OOM error but we don't

> Does the above patch fix the non-deterministic behaviour?

Yes, I now see 3,2,1,0 and XFAIL all the time. So in order to make this
test reliable I have to move it to a different executable with

static int max_threads = 1;

so that other test cannot interfere with the use of the cache by this
test.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2015-05-06 11:08:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.