[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: client SEGV with --enable-runtime-module-search

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 01 May 2015 17:54:47 +0100

Philip Martin <philip.martin_at_wandisco.com> writes:

> Index: ../src-1.9/subversion/libsvn_ra/ra_loader.c
> ===================================================================
> --- ../src-1.9/subversion/libsvn_ra/ra_loader.c (revision 1677108)
> +++ ../src-1.9/subversion/libsvn_ra/ra_loader.c (working copy)
> @@ -355,7 +355,7 @@ svn_error_t *svn_ra_open4(svn_ra_session_t **sessi
> /* Library not found. */
> continue;
>
> - SVN_ERR(initfunc(svn_ra_version(), &vtable, scratch_pool));
> + SVN_ERR(initfunc(svn_ra_version(), &vtable, sesspool));
>
> SVN_ERR(check_ra_version(vtable->get_version(), scheme));
>
> allows the initialize to work again.

For ra_local the initfunc is svn_ra_local__init and it contains a
comment:

#ifndef SVN_LIBSVN_CLIENT_LINKS_RA_LOCAL
  /* This assumes that POOL was the pool used to load the dso. */
  SVN_ERR(svn_fs_initialize(pool));
#endif

Passing scratch_pool breaks the assumption in the comment since
scratch_pool was not used to load the DSO.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2015-05-02 23:45:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.