[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1676535 - /subversion/trunk/subversion/tests/libsvn_subr/io-test.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 28 Apr 2015 16:42:56 +0100

Ivan Zhakov <ivan_at_visualsvn.com> writes:

>> What does "can be installed using Windows checkouts much slower than
>> Unix" mean?
>>
> I have no idea. This function was added in r1559758 [1] as preparation
> to fix issue #4450 "Windows checkouts much slower then Unix" [2]. May
> issue summary leaked to function docstring for some reason.

I suspect it should be "can be installed using platform specific
optimizations". Perhaps with something additional about closing the
stream before installing.

Is closing before installing just allowed or is it required? Before
your commit I wrote a patch that closed the stream *after* calling
svn_stream__install_stream and that was sufficient for the test to pass.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2015-04-28 17:43:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.