[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1676535 - /subversion/trunk/subversion/tests/libsvn_subr/io-test.c

From: Branko Čibej <brane_at_wandisco.com>
Date: Tue, 28 Apr 2015 16:56:49 +0200

On 28.04.2015 15:45, ivan_at_apache.org wrote:
> Author: ivan
> Date: Tue Apr 28 13:45:42 2015
> New Revision: 1676535
>
> URL: http://svn.apache.org/r1676535
> Log:
> Follow-up to r1676526: Close install_stream in test.
>
> * subversion/tests/libsvn_subr/io-test.c
> (test_install_stream_to_longpath): Close stream before calling
> svn_stream__install_stream().
>
> Modified:
> subversion/trunk/subversion/tests/libsvn_subr/io-test.c
>
> Modified: subversion/trunk/subversion/tests/libsvn_subr/io-test.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_subr/io-test.c?rev=1676535&r1=1676534&r2=1676535&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/tests/libsvn_subr/io-test.c (original)
> +++ subversion/trunk/subversion/tests/libsvn_subr/io-test.c Tue Apr 28 13:45:42 2015
> @@ -768,6 +768,7 @@ test_install_stream_to_longpath(apr_pool
> final_abspath = svn_dirent_join(deep_dir, "stream1", pool);
> SVN_ERR(svn_stream__create_for_install(&stream, deep_dir, pool, pool));
> SVN_ERR(svn_stream_puts(stream, "stream1 content"));
> + SVN_ERR(svn_stream_close(stream));
> SVN_ERR(svn_stream__install_stream(stream,
> final_abspath,
> TRUE,

Um, surely that can't be right? Using the stream after it's been closed?

-- Brane
Received on 2015-04-28 16:58:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.