On 24.04.2015 06:34, Branko Čibej wrote:
> On 22.03.2015 05:06, Branko Čibej wrote:
>> On 21.03.2015 16:23, Branko Čibej wrote:
>>> On 19.03.2015 11:43, Marc Strapetz wrote:
>>>> Attached example performs an endless series of remote status against
>>>> the Subversion repository. When invoked with -Xmx24M, the VM will run
>>>> out of memory soon. Monitoring with jvisualvm shows that the used heap
>>>> size constantly grows. Monitoring with the Task Manager shows that the
>>>> allocated memory grows even more (significantly). Looks like a memory
>>>> leak, for which a large amount of native memory is involved, too.
>>>>
>>>> Tested on Windows 8.1 with almost latest Subversion 1.9 JavaHL builds.
>>> I can confirm that this happens on the Mac, too, and it's not a garbage
>>> collector artefact. I'm trying to trace where the leak is happening ...
>>> valgrind with APR pool debugging doesn't tell me much (no surprise there).
>> Just to make sure we weren't doing something bad in our libraries, I
>> wrote a small C program that does the same as your Java example (Ev2
>> shims included), and memory usage is completely steady. So it is
>> something in JavaHL, but I have no clue yet what the problem is.
>
> I have to say this was one of the more "interesting" bug-hunts in my not
> entirely boring career, and that's not really obvious from the fix
> itself. :)
>
> http://svn.apache.org/r1675771
>
> Marc: this will not be in RC1, but please give the patch a spin and let
> me know if it fixes your problem. I tested this with the Java program
> you attached to your original report, and heap size no longer grows
> without bounds.
Great hunt, Brane! The native leak seems to be fixed. I've run my remote
status loop with -Xmx24M and still get an OOME after ~170 loop
iterations. The memory leak is significantly smaller and this time it
seems to be in the Java part. According to the profiler, most memory is
allocated by HashMap and friends, referenced from JNI code. Only two
org.apache.subversion classes show up, but I guess they indicate the
source of the leak:
org.apache.subversion.javahl.types.Checksum (~10K instances)
org.apache.subversion.javahl.types.NativeInputStream (~10K instances)
Let me know, if you more profiler statistics will be helpful.
-Marc
Received on 2015-04-24 11:01:29 CEST