[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.9: javahl.ISVNClient#cleanup(String) always fails with "Attemptedto lock an already-locked dir"

From: Branko Čibej <brane_at_wandisco.com>
Date: Thu, 23 Apr 2015 18:15:49 +0200

On 23.04.2015 18:03, Bert Huijben wrote:
> Yes, break locks should be default (as it was in older versions). An
> unsafe default....
>
> Bert
> ------------------------------------------------------------------------
> From: Marc Strapetz <mailto:marc.strapetz_at_syntevo.com>
> Sent: ‎23-‎4-‎2015 16:44
> To: dev_at_subversion.apache.org <mailto:dev_at_subversion.apache.org>
> Subject: 1.9: javahl.ISVNClient#cleanup(String) always fails with
> "Attemptedto lock an already-locked dir"
>
> cleanup-related code which is working fine with 1.8 JavaHL starts
> failing with 1.9 JavaHL.
>
> According to the docs, ISVNClient#cleanup(String) does not break locks,
> which seems to cause the problems:
>
> /**
> * Recursively cleans up a local directory, finishing any
> * incomplete operations, removing lockfiles, etc.
> * <p>
> * Behaves like the 1.9 version with <code>breakLocks</code> and
> * <code>includeExternals</code> set to <code>false<code>, and the
> * other flags to <code>true</code>.
> * @param path a local directory.
> * @throws ClientException
> */
>
> When using ISVNClient.cleanup(path, *true*, true, true, true, false)
> code works.

Looks like I incorrectly wrapped the 1.9 API for 1.8 backward compat ...
thanks for finding this.

http://subversion.tigris.org/issues/show_bug.cgi?id=4575

-- Brane
Received on 2015-04-23 18:21:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.