[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1673170 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_fs_x/ libsvn_ra_local/ libsvn_repos/ mod_dav_svn/ svnserve/ tests/libsvn_ra/

From: Bert Huijben <bert_at_qqmail.nl>
Date: Mon, 13 Apr 2015 16:41:38 +0200

> -----Original Message-----
> From: Ivan Zhakov [mailto:ivan_at_visualsvn.com]
> Sent: maandag 13 april 2015 14:53
> To: dev_at_subversion.apache.org; Bert Huijben
> Subject: Re: svn commit: r1673170 - in /subversion/trunk/subversion: include/
> libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_fs_x/ libsvn_ra_local/
> libsvn_repos/ mod_dav_svn/ svnserve/ tests/libsvn_ra/

> The proper solution would be add new DAV property like
> "has-dead-props", advertise it support using capability header and
> then request it from client instead of "deadprop-count".
>
> What do you think?

The problem is that currently all subversion clients that perform an 'svn ls -v' (including TortoiseSVN) use the existing request. New clients that know about this problem simply don't ask for this property. If we do it as you suggest we don't help old clients and we don't help new clients, while old clients don't have a way to access this integer.

I think we should define a new thing (capability, header, property, whatever) if we ever decide that we are interested in the integer. Given that today we aren't even interested in the boolean value (but do spend a whole lot of server CPU obtaining it - Minutes in my tescases), I don't think it is likely that we ever want the real value, as the other ra layers don't provide the value either.

The best solution would be to do as you suggested, but in that case we need a time machine (or otherwise we should do nothing at all and keep mod_dav as slow as it is today).

In this already bad case I think it is better to tell new servers that we want the real value in the future instead of now spending minutes of server CPU and IO time on a request that could end in seconds, when nobody is interested in the result :(

(I had hoped neon and serf checked for != 0, but they don't)

        Bert
Received on 2015-04-13 16:44:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.