Re: svn commit: r1662867 - in /subversion/trunk/subversion: bindings/swig/ bindings/swig/include/ bindings/swig/python/libsvn_swig_py/ bindings/swig/python/tests/ include/

philip_at_apache.org wrote on Sat, Feb 28, 2015 at 00:51:41 -0000:
> Author: philip
> Date: Sat Feb 28 00:51:41 2015
> New Revision: 1662867
>
> URL: http://svn.apache.org/r1662867
> Log:
> SWIG Python support for svn_fs_lock_many, svn_fs_unlock_many,
> svn_repos_fs_lock_many and svn_repos_unlock_many.
>
> +++ subversion/trunk/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c Sat Feb 28 00:51:41 2015
> +static PyObject *make_ob_error(svn_error_t *err)
> +{
> + if (err)
> + return svn_swig_NewPointerObjString(err, "svn_error_t *", NULL);
> + else
> + return Py_None;

Need to Py_INCREF(Py_None) before passing it to PyObject_CallFunction()'s "O&" formatter.

https://docs.python.org/2/c-api/none.html#c.Py_None

Daniel

> +}
...
> + if ((result = PyObject_CallFunction(py_callback,
> + (char *)"sO&O&O&",
> + path,
> + make_ob_lock, lock,
> + make_ob_error, fs_err,
> + make_ob_pool, pool)) == NULL)
> + {
Received on 2015-02-28 22:55:02 CET