[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1661451 - in /subversion/trunk/subversion: bindings/javahl/native/ bindings/javahl/src/org/apache/subversion/javahl/ bindings/javahl/tests/org/apache/subversion/javahl/ include/ libsvn_client/ svn/ tests/libsvn_client/ tests/libsvn_wc/

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Sun, 22 Feb 2015 15:25:23 +0000

rhuijben_at_apache.org writes:

> Author: rhuijben
> Date: Sun Feb 22 01:36:15 2015
> New Revision: 1661451
>
> URL: http://svn.apache.org/r1661451
> Log:
> Expose the metadataOnly option that is already implemented in libsvn_client's
> copy support through the api.

There is a problem with the underlying libsvn_client change. When
metadata_only is TRUE it causes svn_client_copy7 to pass TRUE for both
metadata_only and allow_mixed_revisions. This then triggers the assert
at ../src/subversion/libsvn_client/copy.c:3056. The caller of
svn_client_copy7 does not control the allow_mixed_revisions setting so
passing metadata_only as TRUE is a bit of a problem.

I hacked the client to pass metadata_only=TRUE to experiment:

Index: ../src/subversion/svn/copy-cmd.c
===================================================================
--- ../src/subversion/svn/copy-cmd.c (revision 1661484)
+++ ../src/subversion/svn/copy-cmd.c (working copy)
@@ -169,7 +169,7 @@
 
   err = svn_client_copy7(sources, dst_path, TRUE,
                          opt_state->parents, opt_state->ignore_externals,
- FALSE /* metadata_only */,
+ TRUE /* metadata_only */,
                          opt_state->pin_externals,
                          NULL, /* pin all externals */
                          opt_state->revprop_table,

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2015-02-22 16:26:44 CET

This is an archived mail posted to the Subversion Dev mailing list.