Re: Handling assertions and malfunctions in mod_dav_svn

Ben Reser <ben_at_reser.org> writes:

> +1 except for the mod_dav_svn: prefix in the log output. httpd should be
> adding that for you with APLOG_MARK.

I committed the patch in r1660480 and chose to keep the "mod_dav_svn:" prefix
for two reasons:

- Other messages nearby use the same prefix.

- If I am not mistaken, in order for the APLOG_MARK() to use the current
  module index, we have to declare mod_dav_svn with APLOG_USE_MODULE(),
  as we do, for example, in mod_authz_svn.c:

    #ifdef APLOG_USE_MODULE
    APLOG_USE_MODULE(authz_svn);
    #else
    /* This is part of the APLOG_USE_MODULE() macro in httpd-2.3 */
    extern module AP_MODULE_DECLARE_DATA authz_svn_module;
    #endif

  Currently we don't do this for mod_dav_svn, so APLOG_MARK is not going to
  automatically include the module name. I am not exactly aware about the
  reasons for not doing this, but I preferred to keep things consistent with
  what's around.

Regards,
Evgeny Kotkov
Received on 2015-02-17 21:02:10 CET