[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue #4467 - blame youngest to oldest needs to handle SVN_INVALID_REVNUM - 1.9 blocker?

From: Branko Čibej <brane_at_wandisco.com>
Date: Tue, 17 Feb 2015 18:00:45 +0100

On 17.02.2015 17:56, Philip Martin wrote:
> Philip Martin <philip.martin_at_wandisco.com> writes:
>
>> Essentially every time we compare start and end we need to make sure
>> that we handle SVN_INVALID_REVNUM properly. I think the functions
>> listed in the issue are a few locations I identified that need to be
>> checked.
> Some of the APIs in svn_ra.h document that SVN_INVALID_REVNUM can be
> passed to mean HEAD, other functions in the file are silent on the
> matter. Is passing SVN_INVALID_REVNUM to mean HEAD supported by
> svn_ra_get_file_revs2, svn_ra_replay_range, etc.

Sadly, the RA layer is not consistent there ... I wouldn't be surprised
if it was inconsistent amongst different RA implementations, too. Needs
code review, IMO.

-- Brane
Received on 2015-02-17 18:01:16 CET

This is an archived mail posted to the Subversion Dev mailing list.