[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1483570 - /subversion/trunk/subversion/libsvn_repos/log.c

From: Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
Date: Wed, 11 Feb 2015 14:04:09 +0300

Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com> writes:

> I had two basic options to fix the bug.
> (1) Use svn_string_compare that is there for exactly that purpose.
> (2) Fall back to low-level C-string ops and hope to get it right this time.
> I chose with option (1). We use the "sizeof(define) -1" construct
> in at least 32 other places already. I simply went the extra mile
> and documented it, which makes it look like something out of
> the ordinary.

Indeed, this huge comment in r1658439 caught my attention, and I thought that
it wasn't something we do a lot. Grepping gives more than a hundred hits on
usages like this one, so I am fine with that.

>> By the way, it looks like this changeset [1] did not really remove the
>> XFail() marker from the new test, so I expect the buildbots to turn red.
> Yes, I noticed that and fixed it in r1658442.

Thank you for fixing this and the problem itself.

Evgeny Kotkov.
Received on 2015-02-11 12:05:42 CET

This is an archived mail posted to the Subversion Dev mailing list.