[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1483570 - /subversion/trunk/subversion/libsvn_repos/log.c

From: Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
Date: Mon, 9 Feb 2015 18:52:11 +0300

Stefan Fuhrmann <stefan2_at_apache.org> writes:

>> As it turns out, this particular micro-optimization makes a data leak
>> possible. This is not a real security issue, as the change happened on
>> trunk and didn't become part of any released version. Still, I think
>> that we should fix this prior to making 1.9 public.
>
> Good catch, Evgeny! Fixed in r1658439.

I wonder if we really should be adding static const svn_string_t's, and using
"sizeof(define) -1" for unknown performance improvements without appropriate
measurements. By the way, it looks like this changeset [1] did not really
remove the XFail() marker from the new test, so I expect the buildbots to
turn red.

[1] http://svn.apache.org/r1658439

Regards,
Evgeny Kotkov
Received on 2015-02-09 16:53:01 CET

This is an archived mail posted to the Subversion Dev mailing list.