[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1658032 - /subversion/trunk/subversion/libsvn_fs_x/hotcopy.c

From: Branko Čibej <brane_at_wandisco.com>
Date: Sat, 07 Feb 2015 10:56:26 +0100

On 07.02.2015 08:48, stefan2_at_apache.org wrote:
> Author: stefan2
> Date: Sat Feb 7 07:48:14 2015
> New Revision: 1658032
>
> URL: http://svn.apache.org/r1658032
> Log:
> * subversion/libsvn_fs_x/hotcopy.c
> (entry_name_to_utf8): It is perfectly acceptable to use a RESULT_POOL
> for the construction of an error object. Hence
> there is no need for a separate SCRATCH_POOL.

While the above may be true in this particular case, it's certainly not
a rule we can apply everywhere. You usually don't know where the result
pool came from and how long its lifetime is.

-- Brane
Received on 2015-02-08 10:19:24 CET

This is an archived mail posted to the Subversion Dev mailing list.