[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix potential crash in libsvn_repos when executing pre-commit hook

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 06 Feb 2015 16:45:47 +0000

Branko Čibej <brane_at_wandisco.com> writes:

>> I would expect this to work in practice as I've never seen a Unix
>> machine without /bin/sh, but I suppose strictly speaking we cannot rely
>> on /bin/sh. Is it portable enough? I suppose we could have a configure
>> variable based on CONFIG_SHELL. Or have a configure variable based on
>> PYTHON and write the hook in python. Or perhaps compile some C to
>> produce an executable and use that by copying it into the repository.
>
> That last would probably the safest thing to do; after all, if we can
> produce binaries, we can write portable hook scripts, too.

I committed the test using /bin/sh, anything else is a lot more work and
possibly more likely to fail than to find a system without /bin/sh.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2015-02-06 17:47:47 CET

This is an archived mail posted to the Subversion Dev mailing list.