[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1657451 - in /subversion/branches/reuse-ra-session: ./ subversion/libsvn_client/

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 5 Feb 2015 15:36:05 +0100

> -----Original Message-----
> From: Ivan Zhakov [mailto:ivan_at_visualsvn.com]
> Sent: donderdag 5 februari 2015 15:30
> To: Branko ─îibej
> Cc: Subversion Development
> Subject: Re: svn commit: r1657451 - in /subversion/branches/reuse-ra-session:
> ./ subversion/libsvn_client/
>
> On 5 February 2015 at 17:22, Branko ─îibej <brane_at_wandisco.com> wrote:
> > On 05.02.2015 11:13, Ivan Zhakov wrote:
> >> On 5 February 2015 at 03:44, <brane_at_apache.org> wrote:
> >>> Author: brane
> >>> Date: Thu Feb 5 00:44:57 2015
> >>> New Revision: 1657451
> >>>
> >>> URL: http://svn.apache.org/r1657451
> >>> Log:
> >>> On the reuse-ra-session branch: Add explicit session reuse in libsvn_client.
> >>>
> >> Cool stuff! Two minor nits are below.
> >
> > Thanks! Fixed in r1657574, along with a few more of the same ilk.
> >
> > I prefer to keep the svn_error_t* return from the release function and
> > write code as if it actually can fail,.
> >
> I don't have opinion what is better, so I'm fine with both approaches.
> Anyway this is private API and we can change it anytime.

Note that using svn_error_compose_create(err1, err2) is sometimes an easy fix for problems like these.

That way the caller gets to see both errors (if there are two) instead of just one.

        Bert
Received on 2015-02-05 15:36:45 CET

This is an archived mail posted to the Subversion Dev mailing list.