Re: svn commit: r1656488 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/client.h libsvn_client/ctx.c libsvn_client/ra.c

On 02.02.2015 16:33, Ivan Zhakov wrote:
> On 2 February 2015 at 18:24, <brane_at_apache.org> wrote:
>> Author: brane
>> Date: Mon Feb 2 15:24:16 2015
>> New Revision: 1656488
>>
>> URL: http://svn.apache.org/r1656488
>> Log:
>> Introduce a private libsvn_client context structure that stores
>> context information that should not be part of the public API.
>>
>> * subversion/include/svn_client.h
>> (svn_client_ctx_t): Remove the 'progress' field, which should be private.
>>
>> * subversion/libsvn_client/client.h
>> (client_ctx_t): New; the private context struct.
>> Contains the equivalent of the 'progress' field.
> I suggest svn_client__private_ctx_t name for client_ctx_t structure: I
> think it less confusing name and follow our guidelines for library
> private identifiers.

This is not really a library private identifier. It is a type name
private to the library, so it's never exposed from a (static or dynamic)
library and therefore cannot cause name collisions at link time.

We use similar type and macro naming shortcuts in many places for this
kind of thing.

I'll probably add a "private_" prefix, though, to avoid confusion where
both context types are used in the same function.

-- Brane
Received on 2015-02-02 16:56:06 CET