Re: svn commit: r1655474 - /subversion/trunk/subversion/tests/cmdline/redirect_tests.py

rhuijben_at_apache.org writes:

> Author: rhuijben
> Date: Wed Jan 28 21:28:07 2015
> New Revision: 1655474
>
> URL: http://svn.apache.org/r1655474
> Log:
> Following up on r1655458, update expected results in redirect tests.
> (This file was missing from that patch)
>
> * subversion/tests/cmdline/redirect_tests.py
> (redirected_copy): Split test. Update expected result.
>
> Modified:
> subversion/trunk/subversion/tests/cmdline/redirect_tests.py
>
> Modified: subversion/trunk/subversion/tests/cmdline/redirect_tests.py
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/redirect_tests.py?rev=1655474&r1=1655473&r2=1655474&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/tests/cmdline/redirect_tests.py (original)
> +++ subversion/trunk/subversion/tests/cmdline/redirect_tests.py Wed Jan 28 21:28:07 2015
> @@ -211,10 +211,18 @@ def redirected_copy(sbox):
>
> sbox.build(create_wc=False)
>
> + # This tests the actual copy handling
> expected_error = "svn: E175011: Repository moved permanently"
> svntest.actions.run_and_verify_svn(None, None, expected_error,
> 'cp', '-m', 'failed copy',
> sbox.redirected_root_url() + '/A',
> + sbox.redirected_root_url() + '/A_copied')
> +
> + # This tests the cmdline handling of '^/copy-of-A'
> + expected_error = "svn: E155007: Resolving '\^/': no repository root found"
> + svntest.actions.run_and_verify_svn(None, None, expected_error,
> + 'cp', '-m', 'failed copy',
> + sbox.redirected_root_url() + '/A',
> '^/copy-of-A')
>

With 1.8 I get:

$ svn cp -mm http://localhost:8888/obj/PERM/repo/A ^/copy
svn: E175011: Repository moved permanently to 'http://localhost:8888/obj/repo/A'; please relocate

with trunk I get:

$ svn cp -mm http://localhost:8888/obj/PERM/repo/A ^/copy
svn: E155007: Resolving '^/': no repository root found in the target arguments or in the current directory

which is a rubbish error message. The point of this test is that it
should report E175011 to show the relocated URL to the user.

I note another problem with trunk:

$ svn ls http://localhost:8888/obj/PERM/repo/A
Redirecting to URL 'pB#.':
svn: E170000: Illegal repository URL 'pB#.'

valgrind gives:

==20604== Invalid read of size 1
==20604== at 0x402CD72: strlen (mc_replace_strmem.c:404)
==20604== by 0x4BA77AE: apr_vformatter (apr_snprintf.c:974)
==20604== by 0x4BB5921: apr_pvsprintf (apr_pools.c:1904)
==20604== by 0x4A6E083: svn_cmdline_printf (cmdline.c:359)
==20604== by 0x42005E: notify_body (notify.c:1020)
==20604== by 0x4204A1: notify (notify.c:1086)
==20604== by 0x40A76FB: svn_client__open_ra_session_internal (ra.c:434)
==20604== by 0x40A7B7B: svn_client__ra_session_from_path2 (ra.c:538)
==20604== by 0x40774A1: list_internal (list.c:262)
==20604== by 0x4077C6A: svn_client_list3 (list.c:468)
==20604== by 0x417549: svn_cl__list (list-cmd.c:367)
==20604== by 0x42BA9C: sub_main (svn.c:3011)
==20604== Address 0x8e6a130 is 0 bytes inside a block of size 33 free'd
==20604== at 0x402AF4C: free (vg_replace_malloc.c:468)
==20604== by 0x4BB51F9: pool_clear_debug (apr_pools.c:1576)
==20604== by 0x4BB534D: pool_destroy_debug (apr_pools.c:1638)
==20604== by 0x4BB5436: apr_pool_destroy_debug (apr_pools.c:1680)
==20604== by 0x41C2330: svn_ra_open4 (ra_loader.c:501)
==20604== by 0x40A767D: svn_client__open_ra_session_internal (ra.c:418)
==20604== by 0x40A7B7B: svn_client__ra_session_from_path2 (ra.c:538)
==20604== by 0x40774A1: list_internal (list.c:262)
==20604== by 0x4077C6A: svn_client_list3 (list.c:468)
==20604== by 0x417549: svn_cl__list (list-cmd.c:367)
==20604== by 0x42BA9C: sub_main (svn.c:3011)
==20604== by 0x42BD85: main (svn.c:3097)
==20604==

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*