[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1655435 - in /subversion/trunk/subversion: libsvn_ra_serf/options.c libsvn_ra_serf/ra_serf.h libsvn_ra_serf/util.c tests/cmdline/redirect_tests.py

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 28 Jan 2015 20:15:56 +0000

rhuijben_at_apache.org writes:

> --- subversion/trunk/subversion/libsvn_ra_serf/util.c (original)
> +++ subversion/trunk/subversion/libsvn_ra_serf/util.c Wed Jan 28 19:16:05 2015
> @@ -1860,6 +1860,12 @@ response_done(serf_request_t *request,
> return svn_error_trace(svn_ra_serf__unexpected_status(handler));
> }
>
> + if ((handler->sline.code >= 300 && handler->sline.code < 399)
> + && !handler->no_fail_on_http_redirect_status)
> + {
> + return svn_error_trace(svn_ra_serf__unexpected_status(handler));
> + }
> +
> return SVN_NO_ERROR;
> }

That ignores handler->session->pending_error while immediately above
this we have:

  if ((handler->sline.code >= 400 || handler->sline.code <= 199)
      && !handler->session->pending_error
      && !handler->no_fail_on_http_failure_status)
    {
      return svn_error_trace(svn_ra_serf__unexpected_status(handler));
    }

Why is the handling different?

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2015-01-28 21:18:43 CET

This is an archived mail posted to the Subversion Dev mailing list.