[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug in svn_stringbuf_insert and svn_stringbuf_replace

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Wed, 14 Jan 2015 01:50:07 +0100

On Fri, Jan 9, 2015 at 7:26 PM, Julian Foad <julianfoad_at_btopenworld.com>
wrote:

> Stefan Fuhrmann wrote:
> [...]
> > Yes, you are right. I'll fix this.
> [...]
> > I'll add test code for these as well.
>
> Thanks.
>

Done in r1650834.

After that you might want to eliminate the recursion, trivially, in both
> functions:
>
> if //it overlaps
> {
> bytes = apr_pmemdup(str->pool, bytes, count);
> // don't recurse here
>
> }
> //continue here with the rest of the function
>

Thanks, that is much better.
Implemented in r1650835.

-- Stefan^2.
Received on 2015-01-14 01:51:23 CET

This is an archived mail posted to the Subversion Dev mailing list.