[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug in svn_stringbuf_insert and svn_stringbuf_replace

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Fri, 9 Jan 2015 18:26:10 +0000

Stefan Fuhrmann wrote:
[...]
> Yes, you are right. I'll fix this.
[...]
> I'll add test code for these as well.

Thanks.

After that you might want to eliminate the recursion, trivially, in both functions:

  if //it overlaps
    {
      bytes = apr_pmemdup(str->pool, bytes, count);
      // don't recurse here

    }
  //continue here with the rest of the function

- Julian
Received on 2015-01-09 19:28:07 CET

This is an archived mail posted to the Subversion Dev mailing list.