Re: Don't reject arguments of the form ".@PEG"

Stefan Sperling wrote:
> On Wed, Oct 29, 2014 at 01:04:21PM +0000, Julian Foad wrote:
>> I (Julian Foad) wrote:
>>> An 'svn' command-line argument of the form "._at_PEG" raises the error
>>>
>>>   svn: E125001: '@PEG' is just a peg revision. Maybe try '@PEG@' instead?
>> [...]
>>> I intend to correct this, to make arguments of the form "._at_PEG"
>>> syntactically acceptable.
>>
>> Committed r1635118.
>
> Don't you think we should bump the API for this?
>
> Whenever I made similar changes in the past (changing just the
> semantics of function arguments) others usually called for a bump.

The change to svn_client_args_to_target_array2 is relaxing an error behaviour that it didn't document in the first place. All usage that worked (didn't error) before will still work. It seems unlikely that anything is relying on this error behaviour in a way that will cause problems, so I don't think that's necessary.

(And svn_opt__split_arg_at_peg_revision is private.)

- Julian
Received on 2014-10-29 14:28:02 CET