[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1624011 - in /subversion/trunk/subversion: libsvn_fs_fs/util.c tests/cmdline/svnadmin_tests.py

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Thu, 18 Sep 2014 15:41:59 +0400

On 10 September 2014 20:12, Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com> wrote:
> Ivan Zhakov <ivan_at_visualsvn.com> writes:
>
>>> +@Skip(svntest.main.is_fs_type_fsx)
>>>
>> I think this test should be skipped for all FS types except FSFS. I.e.
>> @SkipUnless(svntest.main.is_fs_type_fsfs)
>>
>> Did I miss something?
>
> This was intentional.
>
> Prior to this change, we actually had no tests covering the 'svnadmin upgrade'
> behavior, and I took this opportunity to cover all possible --fs-types with the
> new test. We cannot really do this for FSX, because there are no "compatible
> versions", but can do it for BDB and FSFS. Although BDB is deprecated, the
> upgrade code indeed does some amount of work, so I thought there is nothing
> wrong with also testing it.
>
> What I could have done, however, is state this information in the log message
> (for the future readers' sake). I tweaked it accordingly.
>
Ok, that's makes sense. Thanks for explanation.

-- 
Ivan Zhakov
Received on 2014-09-18 13:42:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.