[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1624011 - in /subversion/trunk/subversion: libsvn_fs_fs/util.c tests/cmdline/svnadmin_tests.py

From: Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
Date: Wed, 10 Sep 2014 20:12:42 +0400

Ivan Zhakov <ivan_at_visualsvn.com> writes:

>> +@Skip(svntest.main.is_fs_type_fsx)
>>
> I think this test should be skipped for all FS types except FSFS. I.e.
> @SkipUnless(svntest.main.is_fs_type_fsfs)
>
> Did I miss something?

This was intentional.

Prior to this change, we actually had no tests covering the 'svnadmin upgrade'
behavior, and I took this opportunity to cover all possible --fs-types with the
new test. We cannot really do this for FSX, because there are no "compatible
versions", but can do it for BDB and FSFS. Although BDB is deprecated, the
upgrade code indeed does some amount of work, so I thought there is nothing
wrong with also testing it.

What I could have done, however, is state this information in the log message
(for the future readers' sake). I tweaked it accordingly.

Regards,
Evgeny Kotkov
Received on 2014-09-10 18:13:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.