[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Possible deadlock in named atomic infrastructure used by revprop caching

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Wed, 27 Aug 2014 20:49:07 +0400

On 18 August 2014 16:51, Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com> wrote:
> On Tue, Aug 12, 2014 at 7:22 PM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:
>> Stefan,
>> I've noticed another severe issue in named atomic infrastructure used
>> by revprop caching code while reviewing r1611379 fix:
>> svn_atomic_namespace__create() doesn't release file lock and
>> process-wide mutex (!) on error in libsvn_subr\named_atomic.c:446.
> Thanks for the report, fixed in r1617687.
>> Which is basically mean that server will be deadlocked if *any* of
>> named atomic shared file contains some invalid data.
> That specific error condition means that something randomly
> modified or modifies on-disk data on your server. A deadlock
> is probably not the worst effect in that case ...

What do you consider to be the worst effect here?

Have you considered cloud servers with thousands of repositories that
could be deadlocked because of a SINGLE corrupted repository?

Ivan Zhakov
Received on 2014-08-27 18:49:55 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.