Re: Wunused-but-set-parameter warning in svn_wc_get_diff_editor6
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Fri, 22 Aug 2014 11:52:02 +0100
Philip Martin wrote:
There seems to be more than one problem in that function.
The 'ignore_ancestry' flag should probably be passed to svn_wc__get_diff_editor(..., ignore-ancestry=ignore_ancestry, ...) instead of passing (..., ignore_ancestry=use_git_diff_format, ...). But then where should 'use_git_diff_format' be used?
The 'reverse' flag is used twice: once to construct a reversing filter that will reverse the results; and then again the flag is passed to the diff generator to tell it to generate reversed results. Wouldn't this cause a double-reversal?
I haven't tried to debug it.
This is an archived mail posted to the Subversion Dev mailing list.