[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] remove svn__strtol() and svn__strtoul()

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 6 Aug 2014 20:05:49 +0200

On Wed, Aug 06, 2014 at 07:18:49PM +0200, Branko Čibej wrote:
> On 06.08.2014 18:47, Bert Huijben wrote:
> > Some time ago I switched a few of the calls mentioned here around to
> > get a huge performance improvement on Windows. The standard integer
> > parse functions start by skipping whitespace, and only then parse the
> > integer. But whatever is whitespace is locale dependent, and checking
> > for that from the CTY is really slow on Windows.
> > (If I remember correctly these are exactly the parse id functions you
> > are about to change here)
> In that case, these functions must still perform sanity checks.

If we can't use strtol for this purpose on Windows, then I think we should
introduce our own replacement only on Windows. And also make sure our
replacement is not any less correct in terms of how strtol() behaves otherwise.
Received on 2014-08-06 20:06:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.