[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] remove svn__strtol() and svn__strtoul()

From: Branko Čibej <brane_at_wandisco.com>
Date: Wed, 06 Aug 2014 19:18:49 +0200

On 06.08.2014 18:47, Bert Huijben wrote:
> Some time ago I switched a few of the calls mentioned here around to
> get a huge performance improvement on Windows. The standard integer
> parse functions start by skipping whitespace, and only then parse the
> integer. But whatever is whitespace is locale dependent, and checking
> for that from the CTY is really slow on Windows.
> (If I remember correctly these are exactly the parse id functions you
> are about to change here)

In that case, these functions must still perform sanity checks.

-- Brane

Branko Čibej | Director of Subversion
WANdisco | Realising the impossibilities of Big Data
e. brane_at_wandisco.com
Received on 2014-08-06 19:18:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.