[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1614052 - in /subversion/branches/authzperf/subversion/libsvn_repos: authz.c authz_pool.c repos.h

From: Branko Čibej <brane_at_wandisco.com>
Date: Wed, 30 Jul 2014 16:41:46 +0200

On 28.07.2014 17:21, stefan2_at_apache.org wrote:
> Author: stefan2
> Date: Mon Jul 28 15:21:43 2014
> New Revision: 1614052
> URL: http://svn.apache.org/r1614052
> Log:
> On the authzperf branch: Hide the svn_authz_t definition from
> the headers again. This will allow us to later store prefix tree
> data etc. in that structure.

Stefan^2 , what can we do to make the authz_pool less intrusive? Making
assumptions about what it stores seems like a really bad idea. Can the
pool just store an opaque pointer, or a forward-declared type, and /not/
assume it's an svn_config_t (or svn_authz_t, as it was before your
change)? Does it need the size of the structure, or anything like that?

I'm still not clear on why we need the authz_pool in the first place.
The documentation and code are, to put it mildly, rather dense.


-- Brane

Branko Čibej | Director of Subversion
WANdisco | Realising the impossibilities of Big Data
e. brane_at_wandisco.com
Received on 2014-07-30 16:42:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.