[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

r1550758 - undocumented functions in mtcc.c

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 29 Jul 2014 09:24:20 +0100

> URL: http://svn.apache.org/r1550758
> Log:
> Checkpoint a new libsvn_client api that when tested can replace most of the
> svnmucc code, while re-using some of the commit infrastructure in
> libsvn_client.

Hi Bert. Please could you add doc strings for the static functions (as per 'HACKING')?

Some of them may be simple but I dived in at svn_client_mtcc_add_update_file() and the first thing I wanted to know was what does mtcc_op_find() do -- does it just find an operation in the existing list or does it create operations? -- and that's not trivial.

Thank you.

- Julian

> Added: subversion/trunk/subversion/libsvn_client/mtcc.c
> ==============================================================================

> +
> +static svn_client_mtcc_op_t *
> +mtcc_op_create(const char *name,
> +† † † † † † †† svn_boolean_t add,
> +† † † † † † †† svn_boolean_t directory,
> +† † † † † † †† apr_pool_t *result_pool)

> +
> +static svn_error_t *
> +mtcc_op_find(svn_client_mtcc_op_t **op,
> +† † † † † †† svn_boolean_t *created,
> +† † † † † †† const char *relpath,
> +† † † † † †† svn_client_mtcc_op_t *base_op,
> +† † † † † †† svn_boolean_t find_existing,
> +† † † † † †† svn_boolean_t find_deletes,
> +† † † † † †† svn_boolean_t create_file,
> +† † † † † †† apr_pool_t *result_pool,
> +† † † † † †† apr_pool_t *scratch_pool)

> +
> +static svn_error_t *
> +update_copy_src(svn_client_mtcc_op_t *op,
> +† † † † † † † † const char *add_relpath,
> +† † † † † † † † apr_pool_t *result_pool)

> +
> +static svn_error_t *
> +commit_properties(const svn_delta_editor_t *editor,
> +† † † † † † † † † const svn_client_mtcc_op_t *op,
> +† † † † † † † † † void *node_baton,
> +† † † † † † † † † apr_pool_t *scratch_pool)

> +
> +static svn_error_t *
> +commit_file(const svn_delta_editor_t *editor,
> +† † † † † † svn_client_mtcc_op_t *op,
> +† † † † † † void *file_baton,
> +† † † † † † svn_client_ctx_t *ctx,
> +† † † † † † apr_pool_t *scratch_pool)

> +
> +static svn_error_t *
> +commit_directory(svn_delta_editor_t *editor,
> +† † † † † † † †† svn_client_mtcc_op_t *op,
> +† † † † † † † †† const char *relpath,
> +† † † † † † † †† svn_revnum_t base_rev,
> +† † † † † † † †† void *dir_baton,
> +† † † † † † † †† svn_client_ctx_t *ctx,
> +† † † † † † † †† apr_pool_t *scratch_pool)
Received on 2014-07-29 10:24:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.