[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [serf-dev] Plan to release serf 1.4.0 (+ TODO list)

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Thu, 26 Jun 2014 16:14:18 +0400

On 22 June 2014 14:13, Lieven Govaerts <lgo_at_mobsol.be> wrote:
> Hi,
> I propose we start planning a serf 1.4 release.
> Serf trunk has some features that will be used in the upcoming
> Subversion 1.9, so I'd like to get 1.4 out when the Subversion devs
> start releasing 1.9 release candidates. (When is that planned?) Also,
> I want to start working on HTTP 2.0 support on trunk. This is probably
> going to take me a couple of months and will require some API changes,
> I'd like to get the 1.4 release out of the way first.
> The idea is to create a 1.4.x branch soon, let's say next week Sunday,
> June 30.
June 30 is very tight schedule for me: I'm busy with Subversion 1.9.x
stuff and also
have several things to resolve in serf 1.4.x (see below). Could you
move branch time to
week later at least?

> We can keep backporting changes to that branch for a while,
> but I'd like to release as soon as the API is stable (see TODO list).
> AFAIC that can be by the end of next month.
> Fixes:
> --------
> r2382: Fix problems with NTLM authentication when accessing local
> server using alias hostname (Windows)
While the problem is important, Michael raised some concerns about my fix:

These concerns have to be resolved before branch: probably we need add some
configuration option to change reverse lookup behavior.


> =====
> Blocking the release:
> ---------------------------
> * Finalize get_remaining(): Ivan has added this function to the bucket
> API, but it's only implemented for some buckets.
As far I remember it's implemented for all buckets where length is known.

> I don't think the new API is in use (don't see it in svn trunk). Does it still serve a
> purpose?
This still useful for Subversion. It's currently unused Subversion
only because serf-trunk has version 2.0.0, not 1.4.0


> * Logging: there are some TODO's concerning logging. Logging of raw
> messages is not readable, debugging symbols that need to be removed,
> negative performance impact of config lookup in socket_writev.
I'm still want to review logging changes because personally I would
like to have numbered indexes for configuration options instead of
strings. To avoid use of apr_hash for better performance.

> * set the version to 1.4: I'll do that on the 1.4.x branch.
> Issues I think we should fix in 1.4:
> ---------------------------------------------
> * Fix cancellation of failed requests when an authn callback is set
> (r2360). See the discussion and proposal to fix this:
> https://groups.google.com/d/msg/serf-dev/3_HLwF2lVsY/bcR-fatxGB0J
It still in my todo list :(

> * issue 144: svn commit hangs over https+kerberos. It's not clear to
> me yet what causes this issue, but getting serf in an endless loop is
> an issue we should fix. Not blocking 1.4, I doubt a solution will
> require API changes.
> What about...
> ------------------
> * SSL session sharing? Ivan's work in r1982 to enable reuse of SSL
> sessions was reverted to make place for a better solution. The
> performance benefits of this work were really good, any interest to
> implement the proposed better solution?
> (see https://groups.google.com/d/msg/serf-dev/W6vNiUlMDDw/t1Pnr0Zq-aQJ)
Unfortunetaly I don't have enough time to work on this now, because
I've a lot of things to do this summer. So I think we could defer it
to serf 1.5.0.

> * OCSP stapling support: Justin posted a patch to add OCSP stapling
> support to serf's OpenSSL layer. We can discuss what benefits it will
> actually bring, but AFAIC besides some more code to support there's no
> harm in adding it, and people will use it if it's available (e.g. the
> place I'm working now requires either CRL or OCSP (stapling) support)
> See https://groups.google.com/d/msg/serf-dev/rbFtTyE9E_w/l5lWaBIBDE0J .
It looks like nice feature to have. I didn't tested proposed patch yet.

Ivan Zhakov
Received on 2014-06-26 14:15:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.