On Sat, 2014-06-21 at 13:37 +0000, Daniel Shahaf wrote:
> Carlos MartÃn Nieto wrote on Fri, Jun 20, 2014 at 17:06:53 +0200:
> > Hi,
> > libgit2 v0.21.0 was just released, and there have been some changes to the API.
> Seeing as the patch breaks compatibility with older libgit's, shouldn't
> INSTALL, BRANCH-README, and/or configure.ac be updated to indicate the
> new minimum version?
That makes sense. There is currently no checking, so I figured it wasn't
a big deal due to the experimental nature of this branch, but it
certainly doesn't hurt to specify it.
> (Sorry, no time to review the patch, even though it _does_ look
> > [[[
> > On the â€˜ra-gitâ€™ branch: update to libgit2 v0.21
> > * subversion/libsvn_ra_git/ra_plugin.c:
> > (split_url): remotes which are not in the config are now called anonymous.
> > (do_git_fetch): pass NULL to git_remote_fetch() to get default reflog entries.
> > (remote_progress_cb, svn_ra_git__open): the progress callback has been
> > renamed to sideband_progress. Rename our callback function to
> > remote_sideband_progress_cb to match libgit2 naming.
> > (compare_git_tree_entries): git_tree_entry_byoid is now git_tree_entry_byid.
> > * subversion/libsvn_ra_git/reporter.c:
> > (blob_relatedness_cb): delta file field oid has been renamed to id.
> > ]]]
Received on 2014-06-23 18:07:43 CEST