[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

AW: [Patch] Fix for Issue 3046: document security requirement for hook script arguments

From: Markus Schaber <m.schaber_at_codesys.com>
Date: Thu, 19 Jun 2014 12:01:19 +0000

Hi,

The second iteration of the patch to fix issue 3046 and also add a hint wr/t peg revisions, as inspired by danielsh on IRC while discussing issue 2349. This iteration fixes 2 typos.

[[[
Fix issue 3046 by adding a statement about quoting of parameters. Also
add a hint about peg revisions, while we are at it.

* subversion/libsvn_repos/repos.c
  (create_hooks): Add a hint about quoting of parameters and url
    handling to the hook templates.
]]]

Best regards

Markus Schaber

CODESYS® a trademark of 3S-Smart Software Solutions GmbH

Inspiring Automation Solutions

3S-Smart Software Solutions GmbH
Dipl.-Inf. Markus Schaber | Product Development Core Technology
Memminger Str. 151 | 87439 Kempten | Germany
Tel. +49-831-54031-979 | Fax +49-831-54031-50

E-Mail: m.schaber@codesys.com | Web: http://www.codesys.com | CODESYS store: http://store.codesys.com
CODESYS forum: http://forum.codesys.com

Managing Directors: Dipl.Inf. Dieter Hess, Dipl.Inf. Manfred Werner | Trade register: Kempten HRB 6186 | Tax ID No.: DE 167014915

> -----Ursprüngliche Nachricht-----
> Von: Konstantin Kolinko [mailto:knst.kolinko_at_gmail.com]
> Gesendet: Donnerstag, 19. Juni 2014 13:45
> An: Markus Schaber
> Cc: Subversion Dev (dev_at_subversion.apache.org)
> Betreff: Re: [Patch] Fix for Issue 3046: document security
> requirement for hook script arguments
>
> 2014-06-19 15:08 GMT+04:00 Markus Schaber <m.schaber_at_codesys.com>:
> > Hi,
> >
> > The attached patch fixes issue 3046 and also adds an hint wr/t peg
> revisions, as inspired by danielsh on IRC.
> >
> > [[[
> > Fix issue 3046 by adding a statement about quoting of parameters.
> Also
> > add a hint about peg revisions, while we are at it.
> >
> > * subversion/libsvn_repos/repos.c
> > (create_hooks): Add a hint about quoting of parameters and url
> > Handling to the hook templates.
> > ]]]
>
> Interesting.
>
> A typo in the text:
> s/qoute/quote/
>
> In commit message:
> s/Handling/handling/
>
> Best regards,
> Konstantin Kolinko
Received on 2014-06-19 14:01:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.