[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH V1] Fix the hotcopy messing up the destination db/current for old repositories

From: Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
Date: Wed, 18 Jun 2014 17:52:37 +0200

I committed these three patches in r1603482, r1603485 and r1603486.

> That patch in itself is o.k.. However, you should update
> get_next_revision_ids() in transaction.c to use the new
> utility function (or entirely replace it).

Done as a follow-up in r1603487.

> Removing the internal API is fine; however you might have
> kept the code as a static function without the svn_fs_fs__
> name prefix. There is no need to manually inline it into the
> caller - but that's just me giving an opinion. I'd be fine with
> committing that patch as is.

I committed the patch as is. Otherwise we would end up with a unwanted name
clash (there already is the recover_find_max_ids() function) and, basically,
I cannot think of an appropriate "private" name for this function. What it
essentially does is something like open_file_and_find_max_ids(), but that is
ugly. I think the inlined version is fine.

Thank you for the review!

Evgeny Kotkov
Received on 2014-06-18 17:53:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.