[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

enable packing by default

From: Stefan Sperling <stsp_at_elego.de>
Date: Mon, 16 Jun 2014 15:53:16 +0200

Stefan2 pointed out that format 7 is less efficient if packing is disabled.
So to fully benefit from format 7 in the default configuration, users must
currently run 'svnadmin pack' or edit fsfs.conf to enable packing after commit.
Since format 7 adds locking support to pack, so it should be safe to trigger
packing at any time.

It looks like it makes sense to enable packing after commit by default
for format 7 repositories. Any objections?

[[[
Enable packing by default in format 7 FSFS repositories.

* subversion/libsvn_fs_fs/fs_fs.c
  (read_config): If the file format supports the pack lock, default to
   pack-after-commit.
]]]

Index: subversion/libsvn_fs_fs/fs_fs.c
===================================================================
--- subversion/libsvn_fs_fs/fs_fs.c (revision 1602863)
+++ subversion/libsvn_fs_fs/fs_fs.c (working copy)
@@ -769,7 +769,8 @@ read_config(fs_fs_data_t *ffd,
       SVN_ERR(svn_config_get_bool(config, &ffd->pack_after_commit,
                                   CONFIG_SECTION_DEBUG,
                                   CONFIG_OPTION_PACK_AFTER_COMMIT,
- FALSE));
+ ffd->format < SVN_FS_FS__MIN_PACK_LOCK_FORMAT
+ ? FALSE : TRUE));
     }
   else
     {
Received on 2014-06-16 15:53:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.