[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1592724 - in /subversion/trunk/subversion: include/svn_client.h svn/propget-cmd.c tests/cmdline/prop_tests.py tests/cmdline/svnadmin_tests.py

From: Branko Čibej <brane_at_wandisco.com>
Date: Mon, 19 May 2014 17:32:24 +0200

On 19.05.2014 13:30, Daniel Shahaf wrote:
> Julian Foad wrote on Mon, May 19, 2014 at 12:15:00 +0100:
>> Daniel Shahaf wrote:
>>
>>> URL: http://svn.apache.org/r1592724
>>> Log:
>>> Follow-up to r3265 (r843339): In 'svn propget -r', error out on
>>> non-existing properties.
>> Hi Daniel. Can I ask: Why?
>>
> Because I assumed it would error, realized it didn't, and digging into
> the history revealed that it was probably an unintentional omission.
>
>> This makes 'propget --revprop' inconsistent with 'propget [versioned
>> prop]' which still prints nothing. Did you intend to change both
>> forms, for consistency with 'svnlook'?
>>
> I hadn't checked 'svn propget versioned_prop'. It makes
> sense to me that it should error out on non-existing properties.
>
> Would that be a reasonable course to take? Or does anyone prefer to
> retain the pre-r1592724 behaviour?

Didn't we spend time making sure that recursive operations do /not/
error out in such cases?

-- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane_at_wandisco.com
Received on 2014-05-19 17:33:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.