[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1592724 - in /subversion/trunk/subversion: include/svn_client.h svn/propget-cmd.c tests/cmdline/prop_tests.py tests/cmdline/svnadmin_tests.py

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 19 May 2014 11:30:36 +0000

Julian Foad wrote on Mon, May 19, 2014 at 12:15:00 +0100:
> Daniel Shahaf wrote:
>
> > URL: http://svn.apache.org/r1592724
> > Log:
> > Follow-up to r3265 (r843339): In 'svn propget -r', error out on
> > non-existing properties.
>
> Hi Daniel. Can I ask: Why?
>

Because I assumed it would error, realized it didn't, and digging into
the history revealed that it was probably an unintentional omission.

> This makes 'propget --revprop' inconsistent with 'propget [versioned
> prop]' which still prints nothing. Did you intend to change both
> forms, for consistency with 'svnlook'?
>

I hadn't checked 'svn propget versioned_prop'. It makes
sense to me that it should error out on non-existing properties.

Would that be a reasonable course to take? Or does anyone prefer to
retain the pre-r1592724 behaviour?

Thanks,

Daniel

> Previously, 'svn propget' would print nothing for a nonexistent prop
> (either versioned or revprop), while 'svnlook propget' would issue an
> error for a non-existent prop (either versioned or revprop), which was
> a bit more consistent than what we now have.
>
> - Julian
>
> >
> > * subversion/svn/propget-cmd.c
> > † (svn_cl__propget): Handle the (propval == NULL) case.
> >
> > * subversion/include/svn_client.h
> > † (svn_client_revprop_get): Document API behaviour on non-existing properties.
> >
> > * subversion/tests/cmdline/svnadmin_tests.py
> > † (empty_date): Use exit code to verify lack of property.
> >
> > * subversion/tests/cmdline/prop_tests.py
> > † (revprop_change): Same.† 'propget' was actually already failing (with
> > † † the expected E200017), but the test was ignoring the exit code.
> > † † (I think the before-this-change code can never fail, since
> > † † re.match('cha-ching', 'cha-ching\n') would return False.)
Received on 2014-05-19 13:31:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.