[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r1578670 - Fix the order of node record headers written by svndumpfilter

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 22 Apr 2014 12:07:16 +0100 (BST)

Philip Martin wrote:
> Philip Martin writes:
>> Julian Foad writes:
>>> This commit changes the output format of paths from no leading slash
>>> ('relpath' style) to having a leading slash ('fspath' style). This
>>> seems to be against the desired path format for a dump file, although
>>> the documentation in <notes/dump-load-format.txt> is not explicit.
>>> I noticed this because it crashes  'svnrdump load':
>>> $ svnrdump load file://$PWD/rr < the-dump-filtered
>>> lt-svnrdump: subversion/libsvn_subr/dirent_uri.c:1256: svn_relpath_dirname: Assertion `relpath_is_canonical(relpath)' failed.
>>> Aborted (core dumped)
>>> That's probably a bug in itself; 'svnadmin load' accepts them.

I raised issue #4492 "svnrdump load assertion failure if Node-path starts with a slash".

>> The code at the top of new_node_record explicitly adds a leading '/' if
>> none is present so "node_path + 1" should be a safe way to print the
>> path without a leading '/'.

Philip committed a fix in r1587511.

> dump-load-format.txt says that Node-path is "relative to the repository
> root", and the examples don't have leading slashes, however nothing
> explicitly states that leading slashes are prohibited and a path with a
> leading slash can be interpreted as relative to the root.

I mentioned the need to clarify this within issue #4492.

- Julian
Received on 2014-04-22 13:07:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.