Re: r1578670 - Fix the order of node record headers written by svndumpfilter

Philip Martin <philip.martin_at_wandisco.com> writes:

> Julian Foad <julianfoad_at_btopenworld.com> writes:
>
>> This commit changes the output format of paths from no leading slash
>> ('relpath' style) to having a leading slash ('fspath' style). This
>> seems to be against the desired path format for a dump file, although
>> the documentation in <notes/dump-load-format.txt> is not explicit.
>>
>> I noticed this because it crashes  'svnrdump load':
>>
>> $ svnrdump load file://$PWD/rr < the-dump-filtered
>> lt-svnrdump: subversion/libsvn_subr/dirent_uri.c:1256: svn_relpath_dirname: Assertion `relpath_is_canonical(relpath)' failed.
>> Aborted (core dumped)
>>
>> That's probably a bug in itself; 'svnadmin load' accepts them.
>
> I can't reproduce the SEGV with 1.6, 1.7, 1.8 or trunk.

Ah, missed it was svnrdump.

> The code at the top of new_node_record explicitly adds a leading '/' if
> none is present so "node_path + 1" should be a safe way to print the
> path without a leading '/'.

dump-load-format.txt says that Node-path is "relative to the repository
root", and the examples don't have leading slashes, however nothing
explicitly states that leading slashes are prohibited and a path with a
leading slash can be interpreted as relative to the root.

-- 
Philip