Re: -lintl in SVN_INTL_LIBS and LIBS

On Thu, Mar 13, 2014 at 05:46:35PM +0000, Philip Martin wrote:
> Stefan Sperling <stsp_at_apache.org> writes:
>
> > On Thu, Mar 13, 2014 at 04:16:17PM -0000, stsp_at_apache.org wrote:
> >> Author: stsp
> >> Date: Thu Mar 13 16:16:16 2014
> >> New Revision: 1577223
>
> >> - AC_SEARCH_LIBS(bindtextdomain, [intl], [],
> >> + AC_SEARCH_LIBS(bindtextdomain, [intl],
> >> + [
> >> + SVN_INTL_LIBS="-lintl"
>
> That's not correct. AC_SEARCH_LIBS will start with no libs and will only
> go on to check libintl if it doesn't find the symbol. At this point we
> don't know whether libintl was needed or whether it worked without.

Ah, I see. So we'll probably need to set LIBS to an empty string,
and then check if it was set to anything by AC_SEARCH_LIBS?

> I'm still not really sure why we are trying to set SVN_INTL_LIBS at
> all. Why is LIBS not enough?

Because otherwise it requires a special hack during pkg-config
file generation. See r1577226 which removed the hack.
Received on 2014-03-14 11:10:42 CET