[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: -lintl in SVN_INTL_LIBS and LIBS

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 13 Mar 2014 17:46:35 +0000

Stefan Sperling <stsp_at_apache.org> writes:

> On Thu, Mar 13, 2014 at 04:16:17PM -0000, stsp_at_apache.org wrote:
>> Author: stsp
>> Date: Thu Mar 13 16:16:16 2014
>> New Revision: 1577223

>> - AC_SEARCH_LIBS(bindtextdomain, [intl], [],
>> + AC_SEARCH_LIBS(bindtextdomain, [intl],
>> + [
>> + SVN_INTL_LIBS="-lintl"

That's not correct. AC_SEARCH_LIBS will start with no libs and will only
go on to check libintl if it doesn't find the symbol. At this point we
don't know whether libintl was needed or whether it worked without.

I'm still not really sure why we are trying to set SVN_INTL_LIBS at
all. Why is LIBS not enough?

>> + ],
>> [
>> enable_nls="no"
>> ])
>> @@ -702,9 +705,7 @@ if test "$enable_nls" = "yes"; then
>> AC_SEARCH_LIBS(bindtextdomain, [intl],
>> [
>> enable_nls="yes"
>> - # This is here so that -liconv ends up in LIBS
>> - # if it worked with -liconv.
>> - AC_CHECK_LIB(iconv, libiconv_open)
>> + SVN_INTL_LIBS="-lintl -liconv"
>> ],
>> [
>> AC_MSG_WARN([bindtextdomain() not found. Disabling NLS.])
>> @@ -720,6 +721,8 @@ if test "$enable_nls" = "yes"; then
>> fi
>> fi
>>
>> +AC_SUBST(SVN_INTL_LIBS)
>> +
>> AH_BOTTOM([
>> /* Indicate to translators that string X should be translated. Do not look
>> up the translation at run time; just expand to X. This macro is suitable
>>
>

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2014-03-13 18:47:13 CET

This is an archived mail posted to the Subversion Dev mailing list.