[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1574868 - dump with r0 mergeinfo

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Mon, 10 Mar 2014 11:11:04 +0000 (GMT)

[switching back to plain text]

Branko Čibej wrote:
>> +      /* An error in verifying the mergeinfo must not prevent dumping
>> +         the data. Ignore any such error. */
>> +      svn_error_clear(verify_mergeinfo_revisions(
>> +                        eb->found_old_mergeinfo,
>> +                        mergeinfo_str->data, eb->oldest_dumped_rev,
>> +                        eb->notify_func, eb->notify_baton,
>> +                        pool));
> Shouldn't we at least emit a warning here?

Yes and no.  I still have the patch to do so, but I wanted to commit this simple version first in any case, as it is considerably easier to back-port.

The interesting thing is that this code is only executed on a partial dump, where start revision is greater than 1, and only in order to be able to emit other warnings.  It's not even executed at all during 'verify'.  There is still merit in just adding a warning here, but it could almost be seen as misleading to warn in some cases yet fail to warn during full dumps and during verify.  It seems to me it would be much better to parse the mergeinfo and warn if it's bad in all dumps and especially also during 'verify'.

What do you think?

- Julian
Received on 2014-03-10 12:18:22 CET

This is an archived mail posted to the Subversion Dev mailing list.