[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1572762 - /subversion/trunk/build/ac-macros/serf.m4

From: Ben Reser <ben_at_reser.org>
Date: Fri, 28 Feb 2014 09:46:32 -0800

On 2/28/14, 9:42 AM, C. Michael Pilato wrote:
> I think this follows from the problem of making both symbol-specific and
> top-level changes in a given file. Some folks do this:
> * build/ac-macros/serf.m4:
> Update the description.
> (some_func): Twiddle the deeznits.
> Others dislike the inconsistency, and prefer instead:
> * build/ac-macros/serf.m4:
> (): Update the description.
> (some_func): Twiddle the deeznits.

Yes this is exactly why I was using this form. The first one just looks wrong
to me, but if that's what everyone agrees we should be using then I'll stop
doing the (): bit.

> Once you establish a habit of the latter, it sorta follows that when you have
> only top-level changes, you stick with your established pattern.

I only use the (): form when I have both symbol-specific and top-level changes.

The commit this is in regards to had both. Branko just trimmed the rest when
he replied since he only wanted to talk about the top-level change.
Received on 2014-02-28 18:47:04 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.